For cities: Seattle, Philadelphia & Chicago are favourites of mine. For general landscape: the west coast around Yosemite, the coast itself, etc.
But then again my experience is reasonably limited being only a visitor to the states. I also find that my favourite places to shoot are often tied to experiences I had alongside shooting. Meeting friends in a city and having a good day with them will improve my mood and how I feel about my shooting experience.